From b3a1d9d369fe76f13bbe379691d99fd0a40c892b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E9=9D=A2=E6=9D=A1?=
 <2959393+ccbikai@users.noreply.github.com>
Date: Thu, 25 Jan 2024 11:54:28 +0800
Subject: [PATCH] fix: add trailing slash to links to avoid extra redirects
 (#246)

Add trailing slash to links for improved consistency with RSS links and to avoid unnecessary redirects.

---------

Co-authored-by: satnaing <satnaingdev@gmail.com>
---
 src/components/Breadcrumbs.astro | 2 +-
 src/components/Header.astro      | 8 ++++----
 src/components/Search.tsx        | 2 +-
 src/components/Tag.astro         | 2 +-
 src/layouts/Posts.astro          | 6 +++---
 src/layouts/TagPosts.astro       | 6 +++---
 src/pages/index.astro            | 6 +++---
 src/pages/rss.xml.ts             | 2 +-
 8 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/src/components/Breadcrumbs.astro b/src/components/Breadcrumbs.astro
index 791bda4..70d5b55 100644
--- a/src/components/Breadcrumbs.astro
+++ b/src/components/Breadcrumbs.astro
@@ -44,7 +44,7 @@ breadcrumbList[0] === "tags" &&
           </li>
         ) : (
           <li>
-            <a href={`/${breadcrumb}`}>{breadcrumb}</a>
+            <a href={`/${breadcrumb}/`}>{breadcrumb}</a>
             <span aria-hidden="true">&raquo;</span>
           </li>
         )
diff --git a/src/components/Header.astro b/src/components/Header.astro
index 24c3f91..43a4a71 100644
--- a/src/components/Header.astro
+++ b/src/components/Header.astro
@@ -56,23 +56,23 @@ const { activeNav } = Astro.props;
         </button>
         <ul id="menu-items" class="display-none sm:flex">
           <li>
-            <a href="/posts" class={activeNav === "posts" ? "active" : ""}>
+            <a href="/posts/" class={activeNav === "posts" ? "active" : ""}>
               Posts
             </a>
           </li>
           <li>
-            <a href="/tags" class={activeNav === "tags" ? "active" : ""}>
+            <a href="/tags/" class={activeNav === "tags" ? "active" : ""}>
               Tags
             </a>
           </li>
           <li>
-            <a href="/about" class={activeNav === "about" ? "active" : ""}>
+            <a href="/about/" class={activeNav === "about" ? "active" : ""}>
               About
             </a>
           </li>
           <li>
             <LinkButton
-              href="/search"
+              href="/search/"
               className={`focus-outline p-3 sm:p-1 ${
                 activeNav === "search" ? "active" : ""
               } flex`}
diff --git a/src/components/Search.tsx b/src/components/Search.tsx
index 590b583..e6f39ff 100644
--- a/src/components/Search.tsx
+++ b/src/components/Search.tsx
@@ -112,7 +112,7 @@ export default function SearchBar({ searchList }: Props) {
         {searchResults &&
           searchResults.map(({ item, refIndex }) => (
             <Card
-              href={`/posts/${item.slug}`}
+              href={`/posts/${item.slug}/`}
               frontmatter={item.data}
               key={`${refIndex}-${item.slug}`}
             />
diff --git a/src/components/Tag.astro b/src/components/Tag.astro
index 0775a24..5a4a376 100644
--- a/src/components/Tag.astro
+++ b/src/components/Tag.astro
@@ -13,7 +13,7 @@ const { tag, size = "sm" } = Astro.props;
   }`}
 >
   <a
-    href={`/tags/${tag}`}
+    href={`/tags/${tag}/`}
     transition:name={tag}
     class={`${size === "sm" ? "text-sm" : "text-lg"} pr-2 group`}
   >
diff --git a/src/layouts/Posts.astro b/src/layouts/Posts.astro
index 5d51199..9ee8619 100644
--- a/src/layouts/Posts.astro
+++ b/src/layouts/Posts.astro
@@ -23,7 +23,7 @@ const { currentPage, totalPages, paginatedPosts } = Astro.props;
     <ul>
       {
         paginatedPosts.map(({ data, slug }) => (
-          <Card href={`/posts/${slug}`} frontmatter={data} />
+          <Card href={`/posts/${slug}/`} frontmatter={data} />
         ))
       }
     </ul>
@@ -32,8 +32,8 @@ const { currentPage, totalPages, paginatedPosts } = Astro.props;
   <Pagination
     {currentPage}
     {totalPages}
-    prevUrl={`/posts${currentPage - 1 !== 1 ? "/" + (currentPage - 1) : ""}`}
-    nextUrl={`/posts/${currentPage + 1}`}
+    prevUrl={`/posts${currentPage - 1 !== 1 ? "/" + (currentPage - 1) : ""}/`}
+    nextUrl={`/posts/${currentPage + 1}/`}
   />
 
   <Footer noMarginTop={totalPages > 1} />
diff --git a/src/layouts/TagPosts.astro b/src/layouts/TagPosts.astro
index 53e42a1..ebf169c 100644
--- a/src/layouts/TagPosts.astro
+++ b/src/layouts/TagPosts.astro
@@ -30,7 +30,7 @@ const { currentPage, totalPages, paginatedPosts, tag, tagName } = Astro.props;
     <ul>
       {
         paginatedPosts.map(({ data, slug }) => (
-          <Card href={`/posts/${slug}`} frontmatter={data} />
+          <Card href={`/posts/${slug}/`} frontmatter={data} />
         ))
       }
     </ul>
@@ -41,8 +41,8 @@ const { currentPage, totalPages, paginatedPosts, tag, tagName } = Astro.props;
     {totalPages}
     prevUrl={`/tags/${tag}${
       currentPage - 1 !== 1 ? "/" + (currentPage - 1) : ""
-    }`}
-    nextUrl={`/tags/${tag}/${currentPage + 1}`}
+    }/`}
+    nextUrl={`/tags/${tag}/${currentPage + 1}/`}
   />
 
   <Footer noMarginTop={totalPages > 1} />
diff --git a/src/pages/index.astro b/src/pages/index.astro
index 82b74bc..1ae0874 100644
--- a/src/pages/index.astro
+++ b/src/pages/index.astro
@@ -77,7 +77,7 @@ const socialCount = SOCIALS.filter(social => social.active).length;
             <ul>
               {featuredPosts.map(({ data, slug }) => (
                 <Card
-                  href={`/posts/${slug}`}
+                  href={`/posts/${slug}/`}
                   frontmatter={data}
                   secHeading={false}
                 />
@@ -98,7 +98,7 @@ const socialCount = SOCIALS.filter(social => social.active).length;
               ({ data, slug }, index) =>
                 index < 4 && (
                   <Card
-                    href={`/posts/${slug}`}
+                    href={`/posts/${slug}/`}
                     frontmatter={data}
                     secHeading={false}
                   />
@@ -110,7 +110,7 @@ const socialCount = SOCIALS.filter(social => social.active).length;
     }
 
     <div class="all-posts-btn-wrapper">
-      <LinkButton href="/posts">
+      <LinkButton href="/posts/">
         All Posts
         <svg xmlns="http://www.w3.org/2000/svg"
           ><path
diff --git a/src/pages/rss.xml.ts b/src/pages/rss.xml.ts
index 94afc94..0fc75c3 100644
--- a/src/pages/rss.xml.ts
+++ b/src/pages/rss.xml.ts
@@ -11,7 +11,7 @@ export async function GET() {
     description: SITE.desc,
     site: SITE.website,
     items: sortedPosts.map(({ data, slug }) => ({
-      link: `posts/${slug}`,
+      link: `posts/${slug}/`,
       title: data.title,
       description: data.description,
       pubDate: new Date(data.modDatetime ?? data.pubDatetime),